gtkpod transcoding failures (patch included)

Top Page

Reply to this message
Author: Craig Sanders
Date:  
To: dmo-discussion
Subject: gtkpod transcoding failures (patch included)
two problems found (and fixed):

1. gtkpod was failing to convert ogg files to mp3 when i transferred them
to my ipod.

the man page for oggdec said that using stdout when converting to WAV
was a bad idea (due to stdout not being seekable, which is needed to
rewrite the WAV header), so i modified the gtkpod-convert-common.sh to
use raw format for transcoding ogg files. works fine now.

2. there was also a bug where all transcodes (from any format) were failing
with the error message "tr: misaligned [:upper:] and/or [:lower:]
construct" - i added single-quoutes around the upper and lower regexp
classes to fix that. BTW, this happened on one system but not on another
- no idea why, probably slightly different versions of libraries or
something - both machines track debian unstable with occasional pkgs from
experimental but are not always in sync.



--- gtkpod-convert-common.sh.orig       2010-11-13 14:10:30.842758330 +1100
+++ gtkpod-convert-common.sh    2010-11-13 14:04:32.444283443 +1100
@@ -86,11 +86,11 @@
 # Determine decoder


 # Convert the source extension to lowercase.
-filetype=`echo ${infile_extension}| tr [:upper:] [:lower:]`
+filetype=`echo ${infile_extension}| tr '[:upper:]' '[:lower:]'`
 case "$filetype" in
        flac)   decoder="flac" ; options="-d -c --"  ;;
        oga|ogg|ogv|ogx)
-               decoder="oggdec" ; options="--output - --" ;;
+               decoder="oggdec" ; options="-R --output -" ; ENCODER_OPTS="$ENCODER_OPTS -r" ;;
        m4a)    decoder="faad" ; options="-o -" ;;
        wav)    decoder="" ;;
        *)      exit 4 ;;



craig

ps: i'm not sure if this is the right list to post this to, since AFAIK
there isn't a real bugtracker for DMO...if there's a better place to
send stuff like this to, let me know so i'll know where to send them in
future.

--
craig sanders <cas@???>